-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checkPhase to ensure compiled packages actually work #50
Comments
Unfortunately the registry does not include test directories by default (because build tools like Spago and Pulp ignore them) but we could reconsider that if you want to raise an issue. |
I’m not sure to what extent this should be enforced. The issue with tests is that some tests may be flaky or depend on having an Internet connection. There’s also the issue of how to treat packages with very extensive and computationally heavy tests. Nonetheless, when trying to establish package sets for purenix I ran into the issue that it was difficult to verify if the built packages actually:
I think some of the above could be done by inspecting the |
@thomashoneyman Your point completely escaped me. It would indeed be nice if the test directories were included so that it’s possible to test the package sets even though spago won’t do so by default. It wouldn’t be nice to fetch the test directories separately since then it wouldn’t give as much confidence that the published (tarball) version works. |
Missing FFI files is not an error so to ensure a package set actually works together running tests is important.
The text was updated successfully, but these errors were encountered: