Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim temp directory from path when reporting errors in source code #686

Open
thomashoneyman opened this issue Jan 26, 2024 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@thomashoneyman
Copy link
Member

When a failure happens in the publish pipeline due to a problem with a package's source code, we report the bad files using their full filepath as we have it at the time of the error. For example:

We should trim the temporary directory because it's just noise. The directory will be gone by the time we have a chance to go look at the server filesystem anyways (or, in the case of GitHub Actions, it'll most certainly be gone by the time the workflow completes). This error would then report purescript-punycode/src/Main.purs as the path.

@thomashoneyman thomashoneyman added the good first issue Good for newcomers label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant