Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline symbol parses correctly but is incorrectly hilighted #52

Open
mikesol opened this issue Sep 2, 2020 · 2 comments
Open

Multiline symbol parses correctly but is incorrectly hilighted #52

mikesol opened this issue Sep 2, 2020 · 2 comments

Comments

@mikesol
Copy link

mikesol commented Sep 2, 2020

class Foo (a :: Symbol)

instance fooMultiline1 ::
  Foo
    """


a

"""

test ::
  Foo
    """


a

""" =>
  Unit
test = unit

is legal purescript & compiles fine but the syntax hilighting is off in my vscode editor. When test is defined, it doesn't pick up the multiline string correctly. Incidentally, it seems like GitHub markdown has the same issue!

Screenshot from 2020-09-02 22-38-52

@nwolverson
Copy link
Contributor

Parsing has nothing to do with syntax highlighting, the syntax highlighting in the editor is a horrible regex-based mess. It's also very much line-based. Possibly it is possible to make this work, I guess triple-quote strings work at the term level.

GitHub markdown is using the same grammar so not surprising :)

@wclr
Copy link
Contributor

wclr commented Sep 5, 2021

This should be fixed with #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants