Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAT-1382] : Fixing CI failure due to rubocop #354

Merged
merged 1 commit into from
Sep 11, 2023
Merged

[CAT-1382] : Fixing CI failure due to rubocop #354

merged 1 commit into from
Sep 11, 2023

Conversation

rajat-puppet
Copy link
Contributor

@rajat-puppet rajat-puppet commented Sep 11, 2023 •
edited by Ramesh7
Loading

Summary

Fixing CI failure due to rubocop

Additional Context

  • New version released in rubocop-rspec (v2.24.0) caused regression in linting.
Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is enabled by default, the two new cops are pending and need to be enabled explicitly. (@ydah)

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@Ramesh7 Ramesh7 marked this pull request as ready for review September 11, 2023 15:32
@Ramesh7 Ramesh7 requested a review from a team as a code owner September 11, 2023 15:32
@Ramesh7 Ramesh7 merged commit f3f50ca into main Sep 11, 2023
39 checks passed
@Ramesh7 Ramesh7 deleted the CAT-1382-Fix-CI-Pipeline branch September 11, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ramesh7 Ramesh7 Ramesh7 approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajat-puppet @Ramesh7