Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Bring in new template version #1336

Merged
merged 1 commit into from
Apr 8, 2024
Merged

(MAINT) Bring in new template version #1336

merged 1 commit into from
Apr 8, 2024

Conversation

david22swan
Copy link
Member

Any changes made to the pdk-templates generated Gemfile need to be brought into the PDK between releases in order for the tests to function as they should.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Any changes made to the pdk-templates generated Gemfile need to be brought into the PDK between releases in order for the tests to function as they should.
@david22swan david22swan added the maintenance Internal maintenance work that shouldn't appear in the changelog label Apr 8, 2024
@david22swan david22swan requested a review from a team as a code owner April 8, 2024 15:13
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (ff6ae2b) to head (9e304de).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1336   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         133      133           
  Lines        5666     5666           
=======================================
  Hits         5015     5015           
  Misses        651      651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 merged commit 3babe3c into main Apr 8, 2024
13 checks passed
@jordanbreen28 jordanbreen28 deleted the template_bump branch April 8, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants