(CAT-1628) Generalize version selection tests #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests to check against installing the Major versions of the PDK. This is due to the test environment only having certain versions available to install and thus necessitating that the version be update more often than is preferred.
david22swan
added
the
maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1335 +/- ##
=======================================
Coverage 88.51% 88.51%
=======================================
Files 133 133
Lines 5666 5666
=======================================
Hits 5015 5015
Misses 651 651 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests to check against installing the Major versions of the PDK. This is due to the test environment only having certain versions available to install and thus necessitating that the version be updated more often than is preferred.
With this change that is no longer necessary and the test should not need to be updated again in this manner until the release of Puppet 9.
Checklist