Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1570:CAT-1754) Version updates to code #1333

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Mar 28, 2024

Summary

  1. Update expected Puppet versions within the version_selection_spec.rb
  2. Update pinned pdk-template version to match pre-release pin
  3. Remove un-needed code block from update_module_spec.rb

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

These versions must be kept up to date to prevent issues with the Integration tests.
The removed code is no longer necessary as the .sync.yml no longer contains any references to the Gemfile.
@david22swan david22swan added the maintenance Internal maintenance work that shouldn't appear in the changelog label Mar 28, 2024
@david22swan david22swan requested a review from a team as a code owner March 28, 2024 17:02
@david22swan
Copy link
Member Author

Screenshot 2024-03-28 at 4 58 50 PM

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (4bce7c5) to head (3cd844a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1333   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         133      133           
  Lines        5666     5666           
=======================================
  Hits         5015     5015           
  Misses        651      651           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmcmaw pmcmaw merged commit 84d42b3 into main Mar 28, 2024
13 checks passed
@pmcmaw pmcmaw deleted the CAT-1750/main/update-puppet-versions branch March 28, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants