Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1618) - Add Code Coverage to CI #1303

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

jordanbreen28
Copy link
Contributor

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 added the maintenance Internal maintenance work that shouldn't appear in the changelog label Jan 8, 2024
@jordanbreen28 jordanbreen28 force-pushed the CAT-1618-add_code_cov branch from 9f3a724 to 45b364c Compare January 8, 2024 11:10
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 340 lines in your changes are missing coverage. Please review.

Comparison is base (68321bd) 91.25% compared to head (7c9591e) 88.50%.
Report is 344 commits behind head on main.

Files Patch % Lines
lib/pdk/cli/console.rb 0.00% 103 Missing ⚠️
lib/pdk/cli/release.rb 46.25% 43 Missing ⚠️
lib/pdk/monkey_patches.rb 43.39% 30 Missing ⚠️
lib/pdk/module/build.rb 42.10% 11 Missing ⚠️
lib/pdk/cli/new/fact.rb 41.17% 10 Missing ⚠️
lib/pdk/cli/new/function.rb 44.44% 10 Missing ⚠️
lib/pdk/cli/new/provider.rb 41.17% 10 Missing ⚠️
lib/pdk/cli/get/config.rb 43.75% 9 Missing ⚠️
lib/pdk/cli/new/transport.rb 43.75% 9 Missing ⚠️
lib/pdk/cli.rb 89.18% 8 Missing ⚠️
... and 37 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1303      +/-   ##
==========================================
- Coverage   91.25%   88.50%   -2.75%     
==========================================
  Files         137      133       -4     
  Lines        5580     5664      +84     
==========================================
- Hits         5092     5013      -79     
- Misses        488      651     +163     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 force-pushed the CAT-1618-add_code_cov branch from 45b364c to a124d82 Compare January 8, 2024 11:42
@jordanbreen28 jordanbreen28 marked this pull request as ready for review January 8, 2024 13:32
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner January 8, 2024 13:32
@jordanbreen28 jordanbreen28 force-pushed the CAT-1618-add_code_cov branch 2 times, most recently from 7c8ae98 to a7ae5f5 Compare January 8, 2024 14:27
@jordanbreen28 jordanbreen28 marked this pull request as draft January 8, 2024 14:27
@jordanbreen28 jordanbreen28 force-pushed the CAT-1618-add_code_cov branch 6 times, most recently from 97151dd to 4665d29 Compare January 8, 2024 15:54
@jordanbreen28 jordanbreen28 marked this pull request as ready for review January 8, 2024 15:54
@jordanbreen28 jordanbreen28 force-pushed the CAT-1618-add_code_cov branch 4 times, most recently from 593b8d4 to edd13d2 Compare January 15, 2024 10:06
@jordanbreen28 jordanbreen28 marked this pull request as draft January 15, 2024 10:11
@jordanbreen28 jordanbreen28 reopened this Jan 15, 2024
@jordanbreen28 jordanbreen28 force-pushed the CAT-1618-add_code_cov branch 3 times, most recently from f861a16 to eab0f64 Compare January 15, 2024 10:55
Remove the filter for gitignored files. Code coverage will update as per
the diff, which naturally does not include files in .gitignore
@jordanbreen28 jordanbreen28 marked this pull request as ready for review January 15, 2024 11:42
@david22swan david22swan merged commit 10e10cb into main Jan 15, 2024
8 of 10 checks passed
@david22swan david22swan deleted the CAT-1618-add_code_cov branch January 15, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants