Skip to content

Commit

Permalink
(CAT-1618) - Remove unncessary filter for code cov
Browse files Browse the repository at this point in the history
Remove the filter for gitignored files. Code coverage will update as per
the diff, which naturally does not include files in .gitignore
  • Loading branch information
jordanbreen28 committed Jan 15, 2024
1 parent 6d69ffb commit 7c9591e
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

SimpleCov.formatters = [
SimpleCov::Formatter::HTMLFormatter,
SimpleCov::Formatter::Console,
SimpleCov::Formatter::Console
]

if ENV['CI'] == 'true'
Expand All @@ -23,14 +23,6 @@
add_filter '/.vendor'
add_filter '/docs'
add_filter '/lib/pdk/version.rb'

# do not track gitignored files
# this adds about 4 seconds to the coverage check
# this could definitely be optimized
add_filter do |f|
# system returns true if exit status is 0, which with git-check-ignore means file is ignored
system("git check-ignore --quiet #{f.filename}")
end
end
end

Expand Down

0 comments on commit 7c9591e

Please sign in to comment.