Skip to content
This repository has been archived by the owner on Jan 22, 2023. It is now read-only.

Latest commit

 

History

History
21 lines (17 loc) · 517 Bytes

REVIEW.md

File metadata and controls

21 lines (17 loc) · 517 Bytes

REVIEW GUIDE

Main

9 (12 optional) points max

  1. Clean code (DRY, KISS) - 2 points
  2. Layering (single responsibility) - 2 points
  3. Using of cache - 2 points
  4. Using versions to prevent enabling disabled groups until user read a reason - 2 points
  5. Configurable - 1 point
  6. Injection handling - 1 point (if mysql)
  7. (Optional) using Reddis for cache - 2 points

Nice to have 0.5 extra points each

  1. No ORM
  2. docker-compose
  3. tests
  4. linter
  5. using abstract logger
  6. hidden database errors