Remove performance-metrics cron workflow #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean1588
approved these changes
Jul 3, 2024
|
makes sense to me since it has been failing for so long and we no longer need it. |
|
Thanks for tagging me here. We definitely need it to feed the performance alerting system but somehow have not kept up keeping it green so I'm guessing alerting is not setup properly. We should probably reinstate this in a separate repo so that the repo and workflow ownership is aligned with teams and monitoring. CC @mjeffryes |
Yep -- that sounds good to me. 👍🏻 |
cnunciato
added a commit
to pulumi/examples
that referenced
this pull request
Jul 3, 2024
As with pulumi/templates#804, this PR deletes a [long-failing](https://github.com/pulumi/examples/actions/workflows/performance_metrics_cron.yml) workflow no one seems to be using. Fixes #1627.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm assuming since this workflow's been failing for so long, and the failures are due to an error uploading the workflow results to S3 (presumably as a data source for reporting), that no one's actually using the performance data this workflow produces. If that's the case, I'd like to remove the workflow to reduce the maintenance burden on this repo a bit; the "fix" would be fairly simple, but I'd also prefer not to fix and continue maintaining something nobody needs.
Fixes #743.