From 713d905f8b71f00c5392ddd10dbad2d275be302c Mon Sep 17 00:00:00 2001 From: Justin Van Patten Date: Sun, 22 Dec 2024 15:20:09 -0800 Subject: [PATCH] Remove unused npm dependencies It looks like these dependencies aren't actually used anywhere, so stop depending on them. The motivation for this change is that the dependency on `resolve` causes errors to be logged in logs during plugin discovery, because the package includes tests that have malformed `package.json` files. If we don't actually need the dependency it'd be nice to remove it so those errors are no longer logged (so users don't ask us about them). Also remove `read-package-tree` since it is deprecated. Also remove `builtin-modules` since it doesn't appear to be used either. --- provider/cmd/pulumi-resource-vsphere/schema.json | 5 ----- provider/resources.go | 5 ----- sdk/nodejs/package.json | 5 +---- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/provider/cmd/pulumi-resource-vsphere/schema.json b/provider/cmd/pulumi-resource-vsphere/schema.json index 97dd3ad7..1add781a 100644 --- a/provider/cmd/pulumi-resource-vsphere/schema.json +++ b/provider/cmd/pulumi-resource-vsphere/schema.json @@ -32,11 +32,6 @@ "nodejs": { "packageDescription": "A Pulumi package for creating vsphere resources", "readme": "\u003e This provider is a derived work of the [Terraform Provider](https://github.com/hashicorp/terraform-provider-vsphere)\n\u003e distributed under [MPL 2.0](https://www.mozilla.org/en-US/MPL/2.0/). If you encounter a bug or missing feature,\n\u003e first check the [`pulumi-vsphere` repo](https://github.com/pulumi/pulumi-vsphere/issues); however, if that doesn't turn up anything,\n\u003e please consult the source [`terraform-provider-vsphere` repo](https://github.com/hashicorp/terraform-provider-vsphere/issues).", - "dependencies": { - "builtin-modules": "3.0.0", - "read-package-tree": "^5.2.1", - "resolve": "^1.8.1" - }, "devDependencies": { "@types/node": "^10.9.2" }, diff --git a/provider/resources.go b/provider/resources.go index f5bcf388..56a33822 100644 --- a/provider/resources.go +++ b/provider/resources.go @@ -95,11 +95,6 @@ func Provider() tfbridge.ProviderInfo { }}, }, JavaScript: &tfbridge.JavaScriptInfo{ - Dependencies: map[string]string{ - "builtin-modules": "3.0.0", - "read-package-tree": "^5.2.1", - "resolve": "^1.8.1", - }, DevDependencies: map[string]string{ "@types/node": "^10.9.2", }, diff --git a/sdk/nodejs/package.json b/sdk/nodejs/package.json index 6aba52b2..2e766b00 100644 --- a/sdk/nodejs/package.json +++ b/sdk/nodejs/package.json @@ -13,10 +13,7 @@ "build": "tsc" }, "dependencies": { - "@pulumi/pulumi": "^3.142.0", - "builtin-modules": "3.0.0", - "read-package-tree": "^5.2.1", - "resolve": "^1.8.1" + "@pulumi/pulumi": "^3.142.0" }, "devDependencies": { "@types/node": "^10.9.2",