You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is intended to replace the current signature that tries to do inference on the shim.InstanceDiff object that wraps the terraform.InstanceDiff object:
As TF CLI does not access terraform.InstanceDiff but renders diffs by comparing existing and planned state, this would make bridged providers behave more in line with TF expected behavior.
The schema-aware requirement comes down to keep tracking schema (SchemaInfo/SchemaMap) or else current paths through the transformation. When diffing collections, the algo needs to be able to tell when the two diffed PropertyValue arrays are representing a TF set under the hood. PropertyPathToSchemaPath and LookupSchemas can be helpful here.
#2200 outlines a suggestion for how set collection diffs should be handled. The cases where plannedState has unknowns with sets are a bit under-specified, suggest treating the entire new set as an unknown in that case old => UNKNOWN.
This change should be flagged together with all the other work in the epic for a consistent rollout.
The text was updated successfully, but these errors were encountered:
t0yv0
changed the title
[2] Implement schema-aware diffing for detail diff
Implement schema-aware diffing for detail diff
Aug 9, 2024
The task is to build an algo that compares prior and planned state at Pulumi level.
Resolves #1895
Resolves #186
Resolves #1504
This is intended to replace the current signature that tries to do inference on the
shim.InstanceDiff
object that wraps the terraform.InstanceDiff object:As TF CLI does not access terraform.InstanceDiff but renders diffs by comparing existing and planned state, this would make bridged providers behave more in line with TF expected behavior.
The schema-aware requirement comes down to keep tracking schema (SchemaInfo/SchemaMap) or else current paths through the transformation. When diffing collections, the algo needs to be able to tell when the two diffed PropertyValue arrays are representing a TF set under the hood. PropertyPathToSchemaPath and LookupSchemas can be helpful here.
#2200 outlines a suggestion for how set collection diffs should be handled. The cases where plannedState has unknowns with sets are a bit under-specified, suggest treating the entire new set as an unknown in that case
old => UNKNOWN
.This change should be flagged together with all the other work in the epic for a consistent rollout.
The text was updated successfully, but these errors were encountered: