Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note from upstream property documentation dropped #2260

Open
VenelinMartinov opened this issue Jul 29, 2024 · 3 comments
Open

Note from upstream property documentation dropped #2260

VenelinMartinov opened this issue Jul 29, 2024 · 3 comments
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@VenelinMartinov
Copy link
Contributor

What happened?

We seem to omit notes from upstream property documentation in some cases: pulumi/pulumi-gcp#2252

We should investigate if this is a conflict with our markdown parsing of upstream docs, as these can be important, like in the above case.

Example

pulumi/pulumi-gcp#2252

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@VenelinMartinov VenelinMartinov added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team and removed needs-triage Needs attention from the triage team labels Jul 29, 2024
@iwahbe
Copy link
Member

iwahbe commented Aug 7, 2024

@VenelinMartinov Can you link a version pinned header close to the note we should be including. I couldn't find it in the upstream docs.

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Aug 7, 2024

Added it in pulumi/pulumi-gcp#2252. Seems related to markdown parsing.

@t0yv0
Copy link
Member

t0yv0 commented Dec 19, 2024

@guineveresaenger found as well pulumi/pulumi-snowflake#717

Suspecting pulumi/pulumi-aws#4921 orange-priority issue is caused by this too.

The NOTE in the AWS case is nested (property level).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

3 participants