Reconsider TF plugin SDK fork

[VenelinMartinov]

Hello!

• Vote on this issue by adding a 👍 reaction
• If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

After discussing with @t0yv0, he suggested we might no longer need the plugin sdk fork. Looking at the diff the following changes look eventful:

pulumi/terraform-plugin-sdk@53f910a (fixed) -> this one is the most interesting, related to 64 bit int support and timeouts. Perhaps no longer needed? We should carefully test ths.

pulumi/terraform-plugin-sdk@e2a20ae -> this is an optional optimisation, perhaps we can work that into the providers which need it/ into the bridge with some golink magic?

pulumi/terraform-plugin-sdk@74776a5

The rest of the changes are mostly related to exposing internal functions, which we could put into a separate library.

Affected area/feature

[t0yv0]

In my latest understanding 74776a5 exposing provider internals is actually a little unfortunate, primary motivation was to integrate with as-is detailedDiff computation but with #1895 we should be able to write that correctly now and remove the need for 74776a5.

[iwahbe]

pulumi/terraform-plugin-sdk@53f910a has been removed, since it was causing bugs in the bridge.

[iwahbe]

We should make sure to update https://github.com/pulumi/pulumi-terraform-bridge/blob/master/docs/new-provider.md#githubcompulumiterraform-plugin-sdkv2 when we close this issue.

[VenelinMartinov]

This is blocked on https://github.com/orgs/pulumi/projects/165?pane=issue&itemId=73070471 - we need to change the diff implementation to not require TF internals in order to get rid of the plugin-sdk changes which expose that.

[t0yv0]

Agreed, it's best left for after.

[t0yv0]

Curious if we got a little closer to being able to do this.

[VenelinMartinov]

Yeah, the new diff does not depend on TF Diff internals - once that is rolled out we should be able to revert some of the changes to our fork of the plugin-sdk.