DNS Domain Record fails updating without a change #478
Comments
eljoth
added
kind/bug
|
Hi @eljoth. Thanks for raising an issue here. We'll take a look as soon as we can. |
|
@iwahbe Were you able to repro the issue and provide some ideas for workarounds or possible fixes? |
iwahbe
added
needs-repro
|
I wasn't able to repro. Running the program given yields: Our last release included some changes to how we do diffs. @eljoth is the issue still present on v2.3.16? @eljoth if the problem persists, can you post a pulumi program that we can run in our Civo account to reproduce the issue? |
|
I am using the new version v2.3.16. @iwahbe the updated code you can run is as follows (domainName creation was missing in the upper example) import (
civosdk "github.com/pulumi/pulumi-civo/sdk/v2/go/civo"
)
func main() {
pulumi.Run(func(ctx *pulumi.Context) error {
domainName, err := civosdk.NewDnsDomainName(ctx, "test", &civosdk.DnsDomainNameArgs{
Name: pulumi.String("bringalong.io"),
},
)
if err != nil {
return err
}
if _, err := civosdk.NewDnsDomainRecord(ctx, "74.220.31.244", &civosdk.DnsDomainRecordArgs{
Ttl: pulumi.Int(600),
Type: pulumi.String("A"),
DomainId: domainName.ID(),
Name: pulumi.String("api-stg.bringalong.io"),
Value: pulumi.String("74.220.31.244"),
}); err != nil {
return err
}
return nil
})
}I also investigated the issue with @praneetloke and we could not figure out the issue. |
mikhailshilkov
added
needs-triage
|
Hi @eljoth - thank you for the new program. I also get a diff on preview and then an error on the second However, my error is different: Output of second pulumi preview and up, after creating the record, with detailsMy version of the pulumi program import (
civosdk "github.com/pulumi/pulumi-civo/sdk/v2/go/civo"
"github.com/pulumi/pulumi/sdk/v3/go/pulumi"
)
func main() {
pulumi.Run(func(ctx *pulumi.Context) error {
domainName, err := civosdk.NewDnsDomainName(ctx, "civo-478", &civosdk.DnsDomainNameArgs{
Name: pulumi.String("civofourseveneight.io"),
},
)
if err != nil {
return err
}
if _, err := civosdk.NewDnsDomainRecord(ctx, "74.220.31.244", &civosdk.DnsDomainRecordArgs{
Ttl: pulumi.Int(600),
Type: pulumi.String("A"),
DomainId: domainName.ID(),
Name: pulumi.String("api-stg.civofourseveneight.io"),
Value: pulumi.String("74.220.31.244"),
}); err != nil {
return err
}
return nil
})
}The above code in Terraform presents the same error. I cannot reproduce your particular error - however I noticed from the It appears as though When I set Please let us know if this helps! |
|
HI @guineveresaenger, Even though I obviously did not read the docs correctly, is this a candidate for validation improvement? |
|
Brilliant! Thank you, @guineveresaenger! By the way, I do have one comment though:
I don't think we were seeing this diff or we definitely would have noticed what was going on. Here's a link to the |
|
Yay! I'm glad you're unblocked. 🎉 @praneetloke - I do actually see this diff on my end. on But again, I don't have an exact repro for what you saw. @eljoth - I agree validation can be better here. This would be a fix on the upstream Terraform provider. I'm going to file an issue there and mark this issue as awaiting upstream. 👍 |
|
upstream issue: civo/terraform-provider-civo#211 |
guineveresaenger
added
the
awaiting-upstream
|
@guineveresaenger ah I think perhaps there was a bug in the CLI display (or TF bridge maybe?) that has been fixed since the time @eljoth and I were looking into this. I think it may have been 3.113.0 perhaps that he was on. Everything else was latest at the time then. |
What happened?
I am provisioning my CIVO cloud infrastructure via Pulumi.
On the first run, everything works fine, including provisioning of my DNS Name as well as its record.
Without changing the code, running
pulumi upagain, I get the following error:A
pulumi preview --diffshows no changes:Example
Output of
pulumi aboutAdditional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: