Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove make upstream from preTest #4935

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Remove make upstream from preTest #4935

merged 2 commits into from
Dec 17, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Dec 17, 2024

After pulumi/ci-mgmt#1151 our make targets should now all correctly call make upstream if they need it.

This PR removes the make upstream step from preTest and updates examples/webserver-go/go.mod to no longer break make ci-mgmt.

@blampe blampe changed the title Remove "make upstream" Remove make upstream from preTest Dec 17, 2024
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.41%. Comparing base (df65048) to head (0183dcd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4935   +/-   ##
=======================================
  Coverage   24.41%   24.41%           
=======================================
  Files         360      360           
  Lines      143270   143270           
=======================================
  Hits        34984    34984           
  Misses     108187   108187           
  Partials       99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blampe blampe requested a review from t0yv0 December 17, 2024 19:57
@blampe blampe merged commit f9da959 into master Dec 17, 2024
26 checks passed
@blampe blampe deleted the blampe/make-upstream branch December 17, 2024 21:25
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v6.66.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants