Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws.eks.Cluster opting into EKS Auto Mode with built in node pools is currently requiring the cluster to be replaced #4885

Closed
flostadler opened this issue Dec 5, 2024 · 2 comments
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@flostadler
Copy link
Contributor

flostadler commented Dec 5, 2024

Describe what happened

Users should be able to opt into EKS Auto Mode with existing clusters without requiring the cluster to be recreated. This is possible without using the built in nodepools, but currently not possible if users utilize one of the built in nodepools (system, general-purpose)

The set behavior is:

  • Enabling computeConfig.enabled and setting a computeConfig.nodeRoleArn is a valid in-place change
  • Disabling computeConfig.enabled even with a computeConfig.nodeRoleArn specified is a valid in-place change. The role is essentially a noop at thi point
  • With computeConfig.enabled, changing computeConfig.nodeRoleArn from one ARN value to another is not a valid in-place change; this change can only be made by re-placing the cluster

Currently, opting into EKS Auto Mode with an existing cluster and specifying a computeConfig.nodeRoleArn is wanting to replace the cluster since the nodeRoleArn value is changing (from undefined to defined). This should be a valid transition that does not require replacements.

This is caused by the following upstream bug: hashicorp/terraform-provider-aws#40411

Sample program

n/a

Log output

n/a

Affected Resource(s)

aws.eks.Cluster

Output of pulumi about

pulumi-aws v6.63.0

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@flostadler flostadler added awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). blocked The issue cannot be resolved without 3rd party action. kind/bug Some behavior is incorrect or out of spec labels Dec 5, 2024
@flostadler
Copy link
Contributor Author

The upstream issue has been fixed, waiting for the next upstream release to pull the fix

@flostadler flostadler removed the blocked The issue cannot be resolved without 3rd party action. label Dec 13, 2024
@flostadler flostadler self-assigned this Dec 13, 2024
@flostadler flostadler added resolution/fixed This issue was fixed and removed awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). labels Dec 20, 2024
@flostadler
Copy link
Contributor Author

Fixed by #4925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

1 participant