Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS lambda Nodejs 22 runtime is missing #4875

Closed
curtdept opened this issue Dec 3, 2024 · 3 comments · Fixed by #4880
Closed

AWS lambda Nodejs 22 runtime is missing #4875

curtdept opened this issue Dec 3, 2024 · 3 comments · Fixed by #4880
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@curtdept
Copy link

curtdept commented Dec 3, 2024

Describe what happened

AWS added it to go SDK in https://github.com/aws/aws-sdk-go-v2/blob/release-2024-11-20/service/lambda/CHANGELOG.md#v1670-2024-11-20
That was bumped in the TF provider on hashicorp/terraform-provider-aws@5698f69 and released with 5.77

It doesn't look like the bridge is regenerating this (and other related) file(s)
https://github.com/pulumi/pulumi-aws/blob/master/sdk/nodejs/types/enums/lambda/index.ts
https://github.com/pulumi/pulumi-aws/blob/master/sdk/java/src/main/java/com/pulumi/aws/lambda/enums/Runtime.java

This was present in 6.62 prior to retraction as well.

Sample program

aws.lambda.Runtime.NodeJS22dX

Log output

No response

Affected Resource(s)

No response

Output of pulumi about

CLI
Version 3.142.0
Go Version go1.23.3
Go Compiler gc

Plugins
KIND NAME VERSION
resource aws 6.62.0
resource aws 6.61.0
resource awsx 2.19.0
resource docker 4.5.7
resource docker 3.6.1
language nodejs unknown

Host
OS ubuntu
Version 22.04
Arch x86_64

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@curtdept curtdept added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Dec 3, 2024
@flostadler
Copy link
Contributor

Hey @curtdept, the provider does not automatically pull in new enum values for the lambda runtimes. This is maintained manually at the moment:

{Value: "dotnet6", Name: "Dotnet6"},
{Value: "dotnet7", Name: "Dotnet7"},
{Value: "dotnet8", Name: "Dotnet8"},
{Value: "java11", Name: "Java11"},
{Value: "java17", Name: "Java17"},
{Value: "java21", Name: "Java21"},
{Value: "java8.al2", Name: "Java8AL2"},
{Value: "nodejs18.x", Name: "NodeJS18dX"},
{Value: "nodejs20.x", Name: "NodeJS20dX"},
{Value: "provided.al2", Name: "CustomAL2"},
{Value: "provided.al2023", Name: "CustomAL2023"},
{Value: "python3.10", Name: "Python3d10"},
{Value: "python3.11", Name: "Python3d11"},
{Value: "python3.12", Name: "Python3d12"},
{Value: "python3.8", Name: "Python3d8"},
{Value: "python3.9", Name: "Python3d9"},
{Value: "ruby3.2", Name: "Ruby3d2"},

I checked 6.62.0 to be sure and it wasn't part of that release:

Dotnet6: "dotnet6",
Dotnet7: "dotnet7",
Dotnet8: "dotnet8",
Java11: "java11",
Java17: "java17",
Java21: "java21",
Java8AL2: "java8.al2",
NodeJS18dX: "nodejs18.x",
NodeJS20dX: "nodejs20.x",
CustomAL2: "provided.al2",
CustomAL2023: "provided.al2023",
Python3d10: "python3.10",
Python3d11: "python3.11",
Python3d12: "python3.12",
Python3d8: "python3.8",
Python3d9: "python3.9",
Ruby3d2: "ruby3.2",

I'm gonna track this as an enhancement and create a PR right away to add this new runtime

@flostadler flostadler added kind/enhancement Improvements or new features and removed kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Dec 4, 2024
@flostadler flostadler self-assigned this Dec 4, 2024
@curtdept
Copy link
Author

curtdept commented Dec 4, 2024

@flostadler thank you :)

The 6.62 part was ambiguously worded on my part. I meant the runtime values were also missing in that release. In retrospect, that whole sentence could have been left out :( Apologies.

@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 4, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #4880 and shipped in release v6.64.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants