Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Firewall Rule/RuleGroup Documentation: One of the examples doesn't apply to Pulumi's implementation #1998

Closed
MitchellGerdisch opened this issue Jun 8, 2022 · 3 comments
Labels
area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec resolution/no-repro This issue wasn't able to be reproduced

Comments

@MitchellGerdisch
Copy link

What happened?

This example: https://www.pulumi.com/registry/packages/aws/api-docs/networkfirewall/rulegroup/#stateful-inspection-for-permitting-packets-from-a-source-ip-address
shows the use of a "dynamic" property which doesn't exist in Pulumi.
From looking at the analogous terraform provider (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/networkfirewall_rule_group#stateful-inspection-for-permitting-packets-from-a-source-ip-address), it appears this "dynamic" construct is provided in terraform to support a looping mechanism to declare multiple rules.
However, in Pulumi, this would be done using a standard for-loop for the given language and then creating rules ala the DROP example here: https://www.pulumi.com/registry/packages/aws/api-docs/networkfirewall/rulegroup/#stateful-inspection-for-blocking-packets-from-going-to-an-intended-destination

Steps to reproduce

Look at the docs.

Expected Behavior

The examples for the different languages should demonstrate the use of a language-specific for-loop to accomplish the intent of the example.

Actual Behavior

The "dynamic" property doesn't exist.

Versions used

No response

Additional context

You can work around this by using a for-loop over the dynamic property and create the Rule in the body of the for-loop.

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@MitchellGerdisch MitchellGerdisch added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jun 8, 2022
@jkisk
Copy link
Contributor

jkisk commented Jun 8, 2022

@jkodroff do you think we should apply an overlay here?

@jkisk jkisk removed the needs-triage Needs attention from the triage team label Jun 8, 2022
@stack72 stack72 added the area/docs Improvements or additions to documentation label Jun 15, 2022
@stack72
Copy link
Contributor

stack72 commented Jun 15, 2022

This is largely a problem with programgen and it's inability to understand the new HCL syntax :/ We will need to track this when the tf2pulumi changes happen

@mikhailshilkov mikhailshilkov added the resolution/no-repro This issue wasn't able to be reproduced label Nov 4, 2023
@mikhailshilkov
Copy link
Member

For better or worse, the above example is not displayed in the docs anymore, it's been replaced with "Coming soon". We need to chase some of those "Coming soon" examples to come back online, but I think this issue in particular can be closed.

@mikhailshilkov mikhailshilkov closed this as not planned Won't fix, can't repro, duplicate, stale Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec resolution/no-repro This issue wasn't able to be reproduced
Projects
None yet
Development

No branches or pull requests

4 participants