From 9ab73d8dd0bf039c7d444b0a41dc352e2f5a699d Mon Sep 17 00:00:00 2001 From: Justin Van Patten Date: Fri, 20 Dec 2024 15:21:13 -0800 Subject: [PATCH] Remove unused npm dependencies It looks like `resolve` and `builtin-modules` dependencies aren't actually used anywhere, so stop depending on them. The motivation for this change is that the dependency on `resolve` causes errors to be logged in logs during plugin discovery, because the package includes its tests that have malformed `package.json` files in its package. If we don't actually need the dependency, it'd be nice to remove it so those errors are no longer logged (so users don't have to ask us about them). Also remove the `builtin-modules` dependency while cleaning this up, since it doesn't appear to be used either AFAICT. --- provider/cmd/pulumi-resource-aws/schema.json | 4 +--- provider/resources.go | 4 +--- sdk/nodejs/package.json | 4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/provider/cmd/pulumi-resource-aws/schema.json b/provider/cmd/pulumi-resource-aws/schema.json index ab3860afa49..bb425ebeb2f 100644 --- a/provider/cmd/pulumi-resource-aws/schema.json +++ b/provider/cmd/pulumi-resource-aws/schema.json @@ -253,9 +253,7 @@ "packageDescription": "A Pulumi package for creating and managing Amazon Web Services (AWS) cloud resources.", "readme": "\u003e This provider is a derived work of the [Terraform Provider](https://github.com/hashicorp/terraform-provider-aws)\n\u003e distributed under [MPL 2.0](https://www.mozilla.org/en-US/MPL/2.0/). If you encounter a bug or missing feature,\n\u003e first check the [`pulumi-aws` repo](https://github.com/pulumi/pulumi-aws/issues); however, if that doesn't turn up anything,\n\u003e please consult the source [`terraform-provider-aws` repo](https://github.com/hashicorp/terraform-provider-aws/issues).", "dependencies": { - "builtin-modules": "3.0.0", - "mime": "^2.0.0", - "resolve": "^1.7.1" + "mime": "^2.0.0" }, "devDependencies": { "@types/mime": "^2.0.0", diff --git a/provider/resources.go b/provider/resources.go index cd33b0447a0..8bfa105e1dd 100644 --- a/provider/resources.go +++ b/provider/resources.go @@ -5275,9 +5275,7 @@ compatibility shim in favor of the new "name" field.`) }, JavaScript: &tfbridge.JavaScriptInfo{ Dependencies: map[string]string{ - "mime": "^2.0.0", - "builtin-modules": "3.0.0", - "resolve": "^1.7.1", + "mime": "^2.0.0", }, DevDependencies: map[string]string{ "@types/node": "^10.0.0", // so we can access strongly typed node definitions. diff --git a/sdk/nodejs/package.json b/sdk/nodejs/package.json index de8c1e7af2a..90d0faba177 100644 --- a/sdk/nodejs/package.json +++ b/sdk/nodejs/package.json @@ -14,9 +14,7 @@ }, "dependencies": { "@pulumi/pulumi": "^3.142.0", - "builtin-modules": "3.0.0", - "mime": "^2.0.0", - "resolve": "^1.7.1" + "mime": "^2.0.0" }, "devDependencies": { "@types/mime": "^2.0.0",