ProgramTest upgrade tests can fail right after recording

[VenelinMartinov]

What happened?

Looks like under some conditions, the upgrade tests fail right after being recorded, when no changes have happened.

In this example, the diff has:

json_match.go:135: [#["stables"]] unexpected value [
              "staging"
            ]

For the resource under test, the staging property is not available in the baseline version and has a default in the newer version. We probably compare a diff using the old version to a diff using the new version?

Example

https://github.com/pulumi/pulumi-aws/actions/runs/8265739539/job/22614819405?pr=3610

Output of pulumi about

pulumi about
CLI
Version      3.108.1
Go Version   go1.22.0
Go Compiler  gc

Host
OS       darwin
Version  14.1.1
Arch     arm64

Backend
Name           pulumi.com
URL            https://app.pulumi.com/venelin-pulumi-corp
User           venelin-pulumi-corp
Organizations  venelin-pulumi-corp, demo, pulumi
Token type     personal

tested on pulumi/pulumi-aws@17db4d7

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).