Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests dispatch Delete calls to the wrong version #111

Open
t0yv0 opened this issue Oct 4, 2024 · 3 comments
Open

Upgrade tests dispatch Delete calls to the wrong version #111

t0yv0 opened this issue Oct 4, 2024 · 3 comments
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 4, 2024

What happened?

There is an issue @flostadler noticed when upgrading EKS provider tests. It seems that the way we are overriding the provider to use the release candidate provider substitutes all the calls, which includes dispatching Delete calls to the WIP provider. When a resource is removed it can't service them anymore.

Example

I'd love a better example as we just discussed this informally.

Output of pulumi about

N/A

Additional context

N/A

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Oct 4, 2024
@danielrbradley
Copy link
Member

Is this not true for real users who are upgrading and find the old resource removed? Or does this only affect the test due to the gRPC attachment method intercepting all delete calls even if they were being sent to the previous version of the provider? If so, this might be an issue of how attach works - we need to target a single version of the provider and not others.

@danielrbradley danielrbradley removed the needs-triage Needs attention from the triage team label Oct 4, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 4, 2024

Or does this only affect the test due to the gRPC attachment method intercepting all delete calls even if they were being sent to the previous version of the provide

I was assuming this is indeed a problem but we need a repro from Florian or some more pointers to confirm

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 4, 2024

f so, this might be an issue of how attach works - we need to target a single version of the provider and not others.

Exactly my thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

2 participants