Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for kubeconfig to kubeConfig #1311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changes for kubeconfig to kubeConfig #1311

wants to merge 1 commit into from

Conversation

jasbir84
Copy link
Contributor

Changes for kubeconfig to kubeConfig

@jasbir84
Changes for kubeconfig to kubeConfig
7821931 
Changes for kubeconfig to kubeConfig
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

@jasbir84
Copy link
Contributor Author

/run-example-tests

1 similar comment
@rshade
Copy link
Contributor

rshade commented Dec 27, 2022

/run-example-tests

@github-actions
Copy link

Please view the results of the PR Build Here

@rshade
Copy link
Contributor

rshade commented Dec 27, 2022

/run-example-tests

@github-actions
Copy link

Please view the results of the PR Build Here

@lukehoban
Copy link
Contributor

The README at https://github.com/pulumi/examples/blob/78219313610809e6a00f5ead0b0b732b9e2bbfba/gcp-java-gke-hello-world/README.md assumes this output is named kubeconfig - so we can't change this without also changing that.

I'm also not certain we need to diverge on naming here - even in TypeScript, which uses the same camelCase naming convention, we name this kubeconfig fairly consistently throughout the examples repo.

Are there other changes to the yamlTemplate necessary for correctness? If so, do you want to remove the other changes and we can address just those pieces?

@lukehoban lukehoban mentioned this pull request Mar 26, 2023
Closed
@scottslowe scottslowe added the awaiting-feedback Blocked on input from the author label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting-feedback Blocked on input from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasbir84 @rshade @lukehoban @scottslowe