Update a number of dotnet examples (mostly aws) #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icies, remove redundant classes
|
Unit tests are failing, looking into them now but also trying to figure a better way to define mocks. |
…stic load balancing and use app load balancing instead
|
@Zaid-Ajaj Should we get this to a merge or close it out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates a bunch of dotnet examples as well as the CI to use latest dotnet v6. It addresses examples
Simplifying the examples to use top-level statements as well as getting rid of big chunks of interpolated JSON strings to use
JsonObjectdefinitions instead (when specifying IAM policies)More to come, this is to make PR size manageable and discuss whether these changes are good for us to apply to the other examples as well