Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-ts-hello-fargate has invalid package dependencies for recent Node versions #1249

Open
lukehoban opened this issue Jul 19, 2022 · 1 comment · May be fixed by #1250
Open

aws-ts-hello-fargate has invalid package dependencies for recent Node versions #1249

lukehoban opened this issue Jul 19, 2022 · 1 comment · May be fixed by #1250
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@lukehoban
Copy link
Contributor

Running npm install in this example fails on Node 16 and later.

➜  aws-ts-hello-fargate git:(master) npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: aws-typescript@undefined
npm ERR! Found: @pulumi/[email protected]
npm ERR! node_modules/@pulumi/aws
npm ERR!   @pulumi/aws@"^5.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @pulumi/aws@"^4.0.0" from @pulumi/[email protected]
npm ERR! node_modules/@pulumi/awsx
npm ERR!   @pulumi/awsx@"^0.30.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/lukehoban/.npm/eresolve-report.txt for a full report.

I suspect this is due to stricter rules for perr dependencies.

More recent versions of awsx like 0.40.0 work fine.
@lukehoban lukehoban added the kind/bug Some behavior is incorrect or out of spec label Jul 19, 2022
@lukehoban lukehoban changed the title aws-ts-fargate-hello-world has invalid package dependencies for recent Node versions aws-ts-hello-fargate has invalid package dependencies for recent Node versions Jul 19, 2022
lukehoban added a commit that referenced this issue Jul 19, 2022
@lukehoban
[aws-ts-hello-fargate] Use valid set of dependencies.
7b0c4a5 
Fixes #1249.
@lukehoban lukehoban linked a pull request Jul 19, 2022 that will close this issue
Open
@scottslowe
Copy link
Contributor

PR #1250 definitely fixes this issue (I tested it), but that PR appears to be "stuck" due to a couple of failing tests, and I'm not sure how to get the tests to re-run so we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[aws-ts-hello-fargate] Use valid set of dependencies. pulumi/examples
2 participants
@lukehoban @scottslowe