Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Enhancement - Visible version tags for docs that provide code examples #9665

Open
toriancrane opened this issue Aug 11, 2023 · 2 comments · Fixed by pulumi/pulumi-hugo#3720
Labels
area/docs Improvements or additions to documentation kind/enhancement Improvements or new features

Comments

@toriancrane
Copy link
Contributor

toriancrane commented Aug 11, 2023

Description

Dependency on #674

In reviewing issues across the repos, I have seen a few issues come up as a result of the code examples provided in a guide/doc being created using a specific version of a package.

Thoughts around adding visible tag(s) to docs where code examples are provided to indicate which version of package/language the doc was written for? Maybe directly under the title of the doc in a similar fashion to how we show the date on blog posts.

image

Example Tags:
AWSX v.1.0.0-beta-7
Python v3.10.12
Go v1.18.9

These tags would serve two purposes:

  • Visual indicator to readers to help avoid things like this or this
  • Potential to be used for some kind of "needs updating" reporting/automation internally

In regards to the latter, when there are updates to Pulumi packages/required language versions (especially breaking updates), that could be used as the trigger point for some automation to kick off and pull a list of all docs with tags that have values less than the updated version. These "older" docs can be automatically added to a board with a docs/needs-update-review or similar tag.

Questions | Considerations

  • How are "breaking changes" detected?
@github-actions github-actions bot added the needs-triage Needs attention from the triage team label Aug 11, 2023
@github-project-automation github-project-automation bot moved this to 🤔 Triage in Docs 📚 Aug 11, 2023
@toriancrane toriancrane changed the title Docs Enhancement - Visible Tags for docs that provide code examples Docs Enhancement - Visible version tags for docs that provide code examples Aug 11, 2023
@cnunciato cnunciato removed the needs-triage Needs attention from the triage team label Aug 21, 2023
@interurban interurban added area/docs Improvements or additions to documentation kind/enhancement Improvements or new features labels Aug 24, 2023
@toriancrane toriancrane moved this from 🤔 Triage to 🧳 Backlog in Docs 📚 Oct 25, 2023
@cnunciato
Copy link
Contributor

As of pulumi/pulumi-hugo#3674, this is now possible -- at least for any code we check into the programs folder, as all dependency files (package.json, go.mod, *.csproj, etc.) are all present and readable. I fiddled with adding a disclosure triangle to show these files as part of the linked PR, but wasn't happy with the UX, so backed it out. But we can definitely do this now once we decide how we want it to look and behave.

@toriancrane
Copy link
Contributor Author

Hi @cnunciato,

Regarding this comment

But we can definitely do this now once we decide how we want it to look and behave.

Given the original request, I think it makes sense to keep this issue open until we actually have this up and visual. I worry that it will fall to the wayside otherwise, and this way we can keep track of the progress.

@toriancrane toriancrane reopened this Dec 13, 2023
@github-actions github-actions bot added the needs-triage Needs attention from the triage team label Dec 13, 2023
@cnunciato cnunciato removed their assignment Jan 4, 2024
@cnunciato cnunciato removed needs-triage Needs attention from the triage team resolution/fixed This issue was fixed labels Jan 4, 2024
@cnunciato cnunciato moved this from 🏁 Done to 🧳 Backlog in Docs 📚 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation kind/enhancement Improvements or new features
Projects
Status: 🧳 Backlog
Development

Successfully merging a pull request may close this issue.

4 participants