Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createListener method not available on awsx.ApplicationLoadBalancer resource #10336

Closed
jimjoes opened this issue Jan 25, 2023 · 5 comments
Closed
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team resolution/fixed This issue was fixed
Milestone

Comments

@jimjoes
Copy link

jimjoes commented Jan 25, 2023

What happened?

The following code from the documentation here gives me a typescript error:

const alb = new awsx.lb.ApplicationLoadBalancer( "authoring-tool-lb" ) const listener = alb.createListener("authoring-tool-listener", { port: 80 });

The error is:
Property 'createListener' does not exist on type 'ApplicationLoadBalancer'.ts(2339)

Untitled

Steps to reproduce

Use code above and see error.

Expected Behavior

The method should be available

Actual Behavior

I received the typescript error

Output of pulumi about

No response

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@jimjoes jimjoes added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jan 25, 2023
@thomas11 thomas11 removed the needs-triage Needs attention from the triage team label Jan 27, 2023
@thomas11
Copy link
Contributor

Hi @jimjoes, apologies for this issue. This snippet is outdated and was missed. We'll queue up a fix.

At a quick glance, it looks like listeners are now specified inline when creating the ALB. The auto-generated API docs have it correct.

@thomas11
Copy link
Contributor

The file with the wrong docs is pulumi-hugo/themes/default/content/docs/guides/crosswalk/aws/elb.md

@madsbuch
Copy link

@thomas11 I am currently facing quite some documentation (both Pulumi and external blogs) that use the createListener.

Do you have some context on this change? Why it was made and how to implement the functionality in other terms?

@thomas11
Copy link
Contributor

Hi @madsbuch, I believe the way to define listeners is now to specify them inline as part of the ALB, via the Listeners property. Unfortunately, I don't have context on the history here.

@cnunciato cnunciato self-assigned this Dec 5, 2023
@cnunciato cnunciato added the resolution/fixed This issue was fixed label Dec 5, 2023
@cnunciato cnunciato transferred this issue from pulumi/pulumi-awsx Dec 5, 2023
@github-actions github-actions bot added the needs-triage Needs attention from the triage team label Dec 5, 2023
@cnunciato cnunciato added this to the 0.97 milestone Dec 5, 2023
@cnunciato
Copy link
Contributor

Fixed via pulumi/pulumi-hugo#3693.

@github-project-automation github-project-automation bot moved this from 🤔 Triage to 🏁 Done in Docs 📚 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team resolution/fixed This issue was fixed
Projects
Archived in project
Development

No branches or pull requests

4 participants