From 9cf3718337e7b11dbe1d50a5cd4a5b1bf4a9ad5e Mon Sep 17 00:00:00 2001 From: DeeDeeG Date: Wed, 13 Dec 2023 02:06:23 -0500 Subject: [PATCH 1/3] ppm: Install with yarn install --production flag Saves ~5-7MB disk space, depending on how you count it. Should make the packaged Pulsar binaries slightly smaller as well. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 137d82617a..1ecb01c101 100644 --- a/package.json +++ b/package.json @@ -282,7 +282,7 @@ "private": true, "scripts": { "build": "electron-rebuild", - "build:apm": "cd ppm && yarn install", + "build:apm": "cd ppm && yarn install --production", "start": "electron --no-sandbox --enable-logging . -f", "dist": "node script/electron-builder.js", "js-docs": "jsdoc2md --files src --configure docs/.jsdoc.json > ./docs/Pulsar-API-Documentation.md", From bccd6673abc2a124ca4f8497bb91e43b0b53692a Mon Sep 17 00:00:00 2001 From: DeeDeeG Date: Sat, 16 Dec 2023 04:00:00 -0500 Subject: [PATCH 2/3] CI: Quote colon-containing value in package test YAML --- .github/workflows/package-tests-linux.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/package-tests-linux.yml b/.github/workflows/package-tests-linux.yml index ab7659fb76..c514cc9a73 100644 --- a/.github/workflows/package-tests-linux.yml +++ b/.github/workflows/package-tests-linux.yml @@ -35,7 +35,7 @@ jobs: run: yarn build - name: build dependencies - run: yarn build:apm + run: "yarn build:apm" - name: build the editor run: (yarn dist deb || yarn dist deb) && mv binaries/*deb pulsar.deb From 935e495a770d534440b8b7b7c26fb06220038026 Mon Sep 17 00:00:00 2001 From: DeeDeeG Date: Fri, 22 Mar 2024 17:56:06 -0400 Subject: [PATCH 3/3] meta: Update yarn build:apm command to work in more situations Should work in CI, too? Worth a try! Thanks @confused-Techie for the suggested fix! Co-authored-by: confused_techie --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 1ecb01c101..b8705a2648 100644 --- a/package.json +++ b/package.json @@ -282,7 +282,7 @@ "private": true, "scripts": { "build": "electron-rebuild", - "build:apm": "cd ppm && yarn install --production", + "build:apm": "yarn --cwd ./ppm install --production", "start": "electron --no-sandbox --enable-logging . -f", "dist": "node script/electron-builder.js", "js-docs": "jsdoc2md --files src --configure docs/.jsdoc.json > ./docs/Pulsar-API-Documentation.md",