We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this Bug Present in the upstream API Server?
What is the Bug
The query-total header is returning the total number of pages, not the total number of results. That's why pagination controls look wrong.
query-total
How to Replicate the Bug
Look at the query-total header on this endpoint:
curl -I "https://api.pulsar-edit.dev/api/packages?service=outline-view&serviceType=provided"
query-total: 4
Now count how many results are returned on the same endpoint for the first page alone:
curl "https://api.pulsar-edit.dev/api/packages?service=outline-view&serviceType=provided" | jq
30
The text was updated successfully, but these errors were encountered:
Here's your problem:
https://github.com/pulsar-edit/package-backend/blob/main/src/database.js#L1625-L1627
Terminology-wise, you probably want to distinguish count and total from each other. Maybe rename them to result-count & total-pages.
count
total
result-count
total-pages
Sorry, something went wrong.
owner
packages
@savetheclocktower Just to clarify, did #215 fully address this concern?
No, I believe this still needs a fix on the frontend.
Thanks for clarifying, just wanting to check in
No branches or pull requests
Is this Bug Present in the upstream API Server?
What is the Bug
The
query-total
header is returning the total number of pages, not the total number of results. That's why pagination controls look wrong.How to Replicate the Bug
Look at the
query-total
header on this endpoint:curl -I "https://api.pulsar-edit.dev/api/packages?service=outline-view&serviceType=provided"
Now count how many results are returned on the same endpoint for the first page alone:
The text was updated successfully, but these errors were encountered: