Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter packages by maintainer name. #1

Closed
1 task done
wlwl2 opened this issue Oct 24, 2022 · 6 comments
Closed
1 task done

Filter packages by maintainer name. #1

wlwl2 opened this issue Oct 24, 2022 · 6 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@wlwl2
Copy link

wlwl2 commented Oct 24, 2022

Have you checked for existing feature requests?

  • Completed

Summary

Currently Atom does not allow us to filter search results by maintainer name.

Enter your response below:

This would allow package maintainers to find their own packages quickly. My guess is that they would usually make
tools that they are using themselves to solve a problem that they've found. This benefits the rest of the community as they do not have to go through the same mistakes as that maintainer.

Any alternatives?

None that I can think of now.

Other examples:

No response

@wlwl2 wlwl2 added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 24, 2022
@FerixFTW
Copy link

I am having trouble understanding exactly what you mean. For installed community packages, Atom does filter out search results if you input the package author's name.

@confused-Techie confused-Techie transferred this issue from pulsar-edit/pulsar Oct 24, 2022
@confused-Techie
Copy link
Member

I've transferred this issue over to the backend repo, as that functionality would have to made available here first. I think this is a totally fine idea, and see no issue with implementing it.

Although as a reminder any enhancements to the Backend API are awaiting a 2.0 release as per the plan of the backend, which you can see more details in the readme of this repo.

Otherwise I'll go ahead and add that to the Backend Roadmap.

Thanks for the contribution!

@wlwl2
Copy link
Author

wlwl2 commented Oct 27, 2022

I am having trouble understanding exactly what you mean. For installed community packages, Atom does filter out search results if you input the package author's name.

This would be in the Atom editor (Install package search). Sorry I forgot to clarify, however, I do not use the website anymore now since the images were not working a long time ago (months ago?), and now there is an increased presence of spam packages on the front page of the website.

Another thing to clarify is that I consider the website and Atom Install search the similar/same things. They pull from the same source and you want to find the same package whatever that pkg may be. This may not be the direction that Pulsar is going, the website and the desktop app may differ which is fine. They might not even have an external website and solely rely on desktop to find packages- I do not know what direction they may go in the far future.

What I mean is that we should not only have one liner search engine. Maybe click on a button that says search by maintainer name or something.

@confused-Techie
Copy link
Member

I am having trouble understanding exactly what you mean. For installed community packages, Atom does filter out search results if you input the package author's name.

This would be in the Atom editor (Install package search). Sorry I forgot to clarify, however, I do not use the website anymore now since the images were not working a long time ago (months ago?), and now there is an increased presence of spam packages on the front page of the website.

Another thing to clarify is that I consider the website and Atom Install search the similar/same things. They pull from the same source and you want to find the same package whatever that pkg may be. This may not be the direction that Pulsar is going, the website and the desktop app may differ which is fine. They might not even have an external website and solely rely on desktop to find packages- I do not know what direction they may go in the far future.

What I mean is that we should not only have one liner search engine. Maybe click on a button that says search by maintainer name or something.

Well to answer some of those questions.

I've moved your issue to this repo because this repo is the 'external website'.

This repo is the API backend, that is already hosted in the cloud, that would be the service that a frontend website talks to, to find packages, as well as the editor itself, the cli and so on. This should be the single source for all of those.

Additionally while I realize that Atom's service does have broken images and many spam packages, this is our new backend. Which has been built from the ground up, and no longer contains any spam packages (as far as we are aware) and is the backend that any recent binary of the Pulsar editor will use for searching within the editor itself.

@Digitalone1
Copy link

This could be made linking packages table to users one. One to many or many to many, we have to decide.

confused-Techie pushed a commit that referenced this issue Dec 26, 2022
@confused-Techie
Copy link
Member

Resolved by #215
The backend now supports the query parameter of owner which will match with the owner of the repository that's been published. For example https://web.pulsar-edit.dev/packages?owner=savetheclocktower

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants