Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename duplicate Downloading Artifacts Progress Report #1370

Closed
wants to merge 1 commit into from

Conversation

gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Feb 22, 2023

fixes: #1369
Requires PR: pulp/pulpcore#3597

@mdellweg
Copy link
Member

Can we think of other solutions? I'd like the stage to only have a single download stage.
Do i see it correctly, that the docs_blob url is available at the time we create the declarative content? Can we make it a second declarative artifact that we extract again before saving? Or we introduce a DeclarativeBlob that is also downloaded in the artifact_download stage. Is the docs blob meant to be an attached artifact for the content unit?

@gerrod3
Copy link
Contributor Author

gerrod3 commented Feb 23, 2023

Can we think of other solutions?

Yes, this is a quick fix for the problem noticed by David after looking into total count.

I'd like the stage to only have a single download stage. Do i see it correctly, that the docs_blob url is available at the time we create the declarative content?

Yes, it's available on the collection version metadata. It's optional though, so it is not always present.

Can we make it a second declarative artifact that we extract again before saving? Or we introduce a DeclarativeBlob that is also downloaded in the artifact_download stage. Is the docs blob meant to be an attached artifact for the content unit?

DocsBlob is a JSON field on the collection-version model. It can't be added as a second declarative artifact without a serious rework. We could however just override the first downloader stage and have it download the docs-blob with the artifact if the url is present.

Do you want me to look into merging this downloader stage into the first artifact downloader stage?

@mdellweg
Copy link
Member

Do you want me to look into merging this downloader stage into the first artifact downloader stage?
Yes, I would prefer that.

I was thinking about a stage between ArtifactDownloader and ArtifactSaver that would find the "extra" d_artifact and turn it into the docs_blob.

@gerrod3 gerrod3 marked this pull request as draft March 3, 2023 15:45
@stale
Copy link

stale bot commented Jun 8, 2023

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label Jun 8, 2023
@stale
Copy link

stale bot commented Jul 9, 2023

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.

@stale stale bot closed this Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate 'Downloading Artifacts' progress report is from the downloading docs blob stage
2 participants