You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pulp_smash.api.safe_handler and pulp_smash.api.json_handler
check for errors in task reports and call reports, and raise TaskReportError or CallReportError respectively if one is found.
As a result, many test methods are no longer necessary. Let's walk through tests that explicitly check call reports and task reports, drop redundant checks, and drop the code that bothers to collect and save those call reports and task reports if possible.
The text was updated successfully, but these errors were encountered:
Had an IRC chat session with @Ichimonji10 and have clarified the following:
Both api.safe_handler and api.json_handler call _handle_202, which calls _check_call_report and _check_tasks. _check_tasks() ensures that each task's "error", "exception" and "traceback" fields. Given that, there's no reason to also check those fields in unit tests.
As of c6308d4,
As a result, many test methods are no longer necessary. Let's walk through tests that explicitly check call reports and task reports, drop redundant checks, and drop the code that bothers to collect and save those call reports and task reports if possible.
The text was updated successfully, but these errors were encountered: