Make rebuilding the app images smarter #694
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrod3
force-pushed
the
ci-app-versions
branch
2 times, most recently
from
d136591
to
7173179
Compare
mdellweg
approved these changes
Nov 22, 2024
| echo "BUILD=true" >> $GITHUB_ENV | ||
| else | ||
| # Script returns non-zero (100) when new versions are available | ||
| if python .ci/scripts/check_for_updates.py ${{ github.ref_name }} versions.freeze; then |
There was a problem hiding this comment.
This name would help reading the if clause:
Suggested change
| if python .ci/scripts/check_for_updates.py ${{ github.ref_name }} versions.freeze; then | |
| if python .ci/scripts/check_up_to_date.py ${{ github.ref_name }} versions.freeze; then |
| if: env.BUILD == 'true' && github.event_name != 'pull_request' | ||
| uses: actions/cache/save@v4 | ||
| with: | ||
| key: ${{ env.VERSIONKEY }} |
There was a problem hiding this comment.
Is this the same cache that we key with base_images={{ env.VERSIONKEY }}?
There was a problem hiding this comment.
It's the same cache container, but not the same entry. base_images={{ env.VERSIONKEY }} was a typo left over from copy-pasting. I fixed it, now the key should only be {{ env.VERSIONKEY }} for the versions.freeze file.
gerrod3
force-pushed
the
ci-app-versions
branch
from
7173179
to
8b5a004
Compare
mdellweg
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the build app image CI for a release (nightly, on-merge, manual) the build action will check to see if it can skip rebuilding the image if no new versions of Pulp have been released for that branch. This should make our nightly runs do less work and avoid publishing what are practically duplicate images.