Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate pyfunnel as a user-defined metric #34

Open
2 tasks
pstelzig opened this issue Jan 19, 2024 · 0 comments
Open
2 tasks

Evaluate pyfunnel as a user-defined metric #34

pstelzig opened this issue Jan 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@pstelzig
Copy link
Owner

Rationale

pyfunnel is a collection of algorithms to compare result timeseries from hybrid simulations (continuous time, discrete event). It is used in BuildingsPy's regression tests. These algorithms are particularly well suited to compare results when there are events and discontinuities in the result timeseries.

CSV Result Compare uses similar algorithms like pyfunnel.

Currently the mopyregtest.metrics collection has no similar built-in metric that allows for error localization in time and that is robust against events occuring at slightly different times.

Proposed feature

Make

  • a proof of concept and
  • a blueprint for other users that uses pyfunnel as a user-defined comparison metric

I think it makes more sense to fall back to an existing an proven solution instead of reproducing a similar functionality natively in MoPyRegtest.

@pstelzig pstelzig added the enhancement New feature or request label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant