Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for different metrics for different models in mopyregtest.Generator #12

Open
pstelzig opened this issue Aug 23, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@pstelzig
Copy link
Owner

Problem description

Right now, all tests generated from a mopyregtest.Generator object use the same metric for all tests it generates. However, it could make sense to use different metrics for different library elements. Right now, this can only be achieved by creating regression test definitions manually, or use different mopyregtest.Generator objects (each of which generates its own test definition file).

Desired behavior

In mopyregtest.Generator have to option to use dedicated comparison metrics for individual Modelica models, and use a default metric for all others.

Potential solution

Use the metric passed to the construtor of mopyregtest.Generator as the default metric, and pass dedicated metrics in the mopyregtest.Generator.generate_tests method, just like with the pre-existing references as a dictionary mapping model name to metric to be used.

@pstelzig pstelzig added the enhancement New feature or request label Aug 23, 2023
@pstelzig pstelzig self-assigned this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant