Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub pages for hosting #157

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Conversation

sharkwouter
Copy link
Member

The system with releases we use right now doesn't work so well. While we are releasing there is a chance that you might not get your package and we have over 300 releases on this repo of which only the last one is ever used.

This PR makes it so we upload to GitHub Pages instead, which then hosts our repo for us. It does not leave old stuff lying around, it just deploys the artifact we give it. We could also later expand it to have a web page in front like @tpimh suggested.

This does require a change in the psp-pacman repo and a rebuild from there after merging. Merging this won't cause errors directly, but the releases will stop being updated. It is possible that in the settings of this repo, GitHub Pages will need to be set to "GitHub Action" before the pipeline goes through.

If you want to make sure it works, I have the exact same workflow file building just fine here: https://github.com/sharkwouter/psp-packages/actions/runs/9390313802

If you change the Server field at the bottom of $PSPDEV/etc/pacman.conf to https://sharkwouter.github.io/psp-packages/ you can test with it and see it in action.

sharkwouter added a commit to pspdev/psp-pacman that referenced this pull request Jun 5, 2024
This should be merged if pspdev/psp-packages#157 gets merged. Since from then on the older repo will no longer be updated.
@fjtrujy fjtrujy merged commit 729bed6 into master Jun 8, 2024
140 checks passed
@diamant3
Copy link
Member

diamant3 commented Jun 8, 2024

but the releases will stop being updated.

could we close the Releases section if that happens? and please add a description to About section of this repo, thanks!

@sharkwouter
Copy link
Member Author

I'll get on deleting all the releases except for the last one and make a PR with some info on how the hosting works. We'll also need to make psp-pacman changes trigger psptoolchain-extra updates. I think we should wait to fully remove the last release, since some people might still be using it.

@sharkwouter sharkwouter deleted the use-github-pages-for-hosting branch June 8, 2024 13:09
@sharkwouter
Copy link
Member Author

Okay, I cleaned up the old releases and tags now. I also made some PRs to make the psp-pacman repo able to force a full rebuild of the entire toolchain:

I still want to create a PR for psp-pacman after which gets rid of the deprecation warning you get when running the workflow.

@sharkwouter
Copy link
Member Author

I created a pull request to clarify how the hosting of the repository works: #160

@sharkwouter
Copy link
Member Author

@diamant3 sort of, I did not use upload-pages-artifact, because it needs gnu tar and we are building on alpine with busybox, and just made my own artifact in the workflow. It works basically the same way, though.

@diamant3
Copy link
Member

diamant3 commented Jun 8, 2024

Got it, right now it's just a server for packages? it means we need a front-end or something to show the packages, right? like the @tpimh suggestion or something like this https://packages.msys2.org/queue

@sharkwouter
Copy link
Member Author

Yeah, we don't have a frontend for it. If you go to the page you get a 404, because we have no index.html. I dunno if msys2-web is the solution here. I would like something that produces static web pages. It should not require a back-end.

@tpimh
Copy link
Contributor

tpimh commented Jun 8, 2024

I believe that just generating one index page + one page for every package is the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants