Skip to content

Commit

Permalink
Version 4.3
Browse files Browse the repository at this point in the history
  • Loading branch information
pschapman committed Oct 9, 2022
1 parent 0fc429f commit 352566c
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 10 deletions.
22 changes: 16 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,20 @@ The current stable version will always be in the master branch.
3. (Optional) Configure Scheduled Task (Windows) or cron job (Mac) to run the script on a regular basis

## What's New
**Version 4.3 - TBD**
**Version 4.3 - 10/9/2022**
- New Features
- NoStats CLI option now fully functional
- Fixed: Multi-controller servers now show disks for all controllers.
- Fixed: Multi-controller servers now show disks for all controllers. (Visible in Server Details)
- Improved: IOM ports now sorted by ID (Visible in IOM Details)
- Improved: Local Disk configuration policy data clarified (Visible under Service Profile Details)
- Code Revisions
- Major performance improvement on stats lookup by filtering initial results.
- Test domain with 1 chassis and 4 blades had ~10K stats records. Filter reduced to ~700. Individual lookups reduced from ~500ms to ~20ms.
- Variable name updates. Duplicate boot order code removed.
- Performance improvements
- Stats lookups base on complete database. Reduced searchable collection by 93% and increased serch performance by 96%. For 8-blade domain, reduced script time by 1/3.
- Removed repetitive calls to UCS where possible. Replaced with single call to get larger collection, then filtered results where the objects are used.
- Identified several additional items during review and marked with TODO. Estimated benefit for fixes is 1-2 seconds for overall script execution.
- Variable names update. Standardized loop triplet: objects, object, objectData.
- Main code block split into ~15 functions.
- Numerous duplicate code blocks consolidated. Where needed, additional logic added to deal with variations.

**Version 4.2 - 9/1/2022**
- New Features
Expand Down Expand Up @@ -130,11 +136,15 @@ The current stable version will always be in the master branch.
## Update Objectives in Progress
- [ ] Improve performance
- [ ] Apply Python style coding practices according to [The PowerShell Style Guide][3]
- [ ] Refactor where possible to make code more DRY and readable
- [ ] Add reporting for the following use cases
- [ ] Port Channels
- [ ] Disjoint L2
- [ ] Call Home Detail
- [X] FC Storage Ports
- [X] Refactor where possible to make code more DRY and readable
- [X] Fix known bugs in existing 2.6 version
- [X] Separate HTML report template (including CSS and JScript) to ease updates
- [X] Change minimum PowerShell version to 5

[1]: https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell-on-macos?view=powershell-7.2
[2]: https://kb.vmware.com/s/article/59235
Expand Down
6 changes: 2 additions & 4 deletions UCS_Config_Report.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ task.
Script Version: 4.3
JSON Schema Version 4.2
Attributions::
Author: Paul S. Chapman ([email protected]) 09/03/2022
Author: Paul S. Chapman ([email protected]) 10/09/2022
History: UCS Configuration Report forked from UCS Health Check v2.6
Source: Brandon Beck ([email protected]) 05/11/2014
Contribution: Marcello Turano
Expand Down Expand Up @@ -1066,6 +1066,7 @@ function Get-SystemData {

return $Data
}

function Get-InventoryFIData {
<#
.DESCRIPTION
Expand Down Expand Up @@ -1628,9 +1629,6 @@ function Get-ServiceProfileIscsiData {
return $Data
}

function Get-ServiceProfileBootOrderData {
}

function Get-ServiceProfilePoliciesData {
param (
$ServiceProfile
Expand Down

0 comments on commit 352566c

Please sign in to comment.