Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: add some workaround for partition renaming partition already exists error #67

Open
1 task done
israpps opened this issue Nov 14, 2022 · 1 comment
Open
1 task done

Comments

@israpps
Copy link
Member

israpps commented Nov 14, 2022

Checks

  • I have checked existing feature requests for duplicates and found none

Describe the FR

fix the partition renaming when user has not edited the segment of the filename wich is processed to be a part of the partition name

i'm not sure if just removing this code will be the solution.

hdl-dump/hdl.c

Lines 1334 to 1336 in 87d3099

} else if (result == RET_OK)
/* partition with such name already exists */
result = RET_PART_EXISTS;

If the solution is that simple, then let me know and i'll make a PR

Describe the solution you'd like

that renaming a game should not trow an error if the game title was not modified on the first ~17 chars

Describe alternatives you've considered

No response

Additional context

No response

@israpps
Copy link
Member Author

israpps commented Nov 14, 2022

another option would be to compare the first 17 chars of both current title and the requested new one.

If they are the same, then avoid that error handling, because, if the part that has influence on the partition name has not been changed, it means there will be no conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant