Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation positioning problem. #18

Open
nitishxyz opened this issue Dec 27, 2018 · 7 comments
Open

Animation positioning problem. #18

nitishxyz opened this issue Dec 27, 2018 · 7 comments
Assignees

Comments

@nitishxyz
Copy link

Animation is behind the icon in simulator but on actual device (Android 9) it's a whole line below. Any solutions?

@prscX prscX self-assigned this Dec 27, 2018
@nitishxyz
Copy link
Author

My physical device has a notch if that may be the cause of the problem, because animation is playing below the button.

@Bunhouth99
Copy link

I also face this issue. any update on this thread?

@prscX
Copy link
Owner

prscX commented Feb 9, 2020

Could you please share the video of the same. I am not able to visualise the problem.

@Bunhouth99
Copy link

@prscX please check gif file below. i have using custom image.
Note: It broken on real device only. old device working fine.(huawei p9 lite)

ezgif com-video-to-gif

@prscX
Copy link
Owner

prscX commented Feb 9, 2020

@Bunhouth99: Got you. I believe, we should render ShineButton post your card is rendered. In componentDidMount you can re-render card component and based on visibility flag you can add ShineButton. Please share your findings.

Thanks
</ Pranav >

@Bunhouth99
Copy link

Bunhouth99 commented Feb 10, 2020

@prscX it still not work. Please kindly check my code below.

const HomeScreen = React.memo(() => {
return (

<View style={{ margin: 15 }}>
<RNShineButton shape={'heart'} color={'#808080'} fillColor={COLORS.primary} size={moderateScale(28)} />


);
});

ezgif com-video-to-gif (1)

Library issue
ChadCSong/ShineButton#48

@prscX
Copy link
Owner

prscX commented Feb 21, 2020

Thanks @Bunhouth99 for sharing the issue link. Once it is fixed I can push the release but until then we need to wait for the fix. Meantime can you try below fix suggested.

issues/48#issuecomment-485328048

Let me know your findings.

Thanks
</ Pranav >

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants