Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed types: grid settings are integers, but $max-width is a string #14

Open
beep opened this issue Jul 25, 2017 · 0 comments
Open

Mixed types: grid settings are integers, but $max-width is a string #14

beep opened this issue Jul 25, 2017 · 0 comments

Comments

@beep
Copy link

beep commented Jul 25, 2017

Since grid settings are all currently integers ($mar: 68; $col: 68; $gut: 26;), but $max-width is defined as a string (e.g., $max-width: 1680px;), it’s a bit tricky to do Sass calculations outside of josef.

For example, $mar / $max-width * 100% results in a Sass compilation error, as it’s asking Sass to divide 68 / 1680px. (Error: 4.04762%/px isn't a valid CSS value.) Manually converting $mar to a string does the trick, though:

( ( $mar + 0px ) / $max-width ) * 100%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant