From ac43a304e88ae90d1391a0f13d2d4e77a7c3869a Mon Sep 17 00:00:00 2001 From: Bartlomiej Plotka Date: Wed, 9 Oct 2024 10:18:59 +0100 Subject: [PATCH] Change default for `--metric-interval` to 0 (breaking change) See related discussion: https://github.com/prometheus-community/avalanche/pull/97#discussion_r1792963626 > I think we should move this default to zero. Essentially I don't see real case of changing metric names in any application. Metric names are generally stable AFAIK, do you know any cases where that's not true? Are they often? cc @jmichalek132 Signed-off-by: Bartlomiej Plotka --- metrics/serve.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metrics/serve.go b/metrics/serve.go index e8a4c2d..c76363e 100644 --- a/metrics/serve.go +++ b/metrics/serve.go @@ -136,7 +136,7 @@ func NewConfigFromFlags(flagReg func(name, help string) *kingpin.FlagClause) *Co IntVar(&cfg.ValueInterval) flagReg("series-interval", "Change series_id label values every {interval} seconds. 0 means no change.").Default("60"). IntVar(&cfg.SeriesInterval) - flagReg("metric-interval", "Change __name__ label values every {interval} seconds. 0 means no change.").Default("120"). + flagReg("metric-interval", "Change __name__ label values every {interval} seconds. 0 means no change.").Default("0"). IntVar(&cfg.MetricInterval) flagReg("series-change-interval", "Change the number of series every {interval} seconds. Applies to 'gradual-change', 'double-halve' and 'spike' modes. 0 means no change.").Default("30"). IntVar(&cfg.SeriesChangeInterval)