-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve examples install instructions #1274
Comments
#1275 is a good example on how to clarify the readme. Help wanted for the rest of the examples! |
I don't think #1275 is a good way to solve this problem. I'll explain myself later (probably tomorrow) but please don't change the other examples before having a discussion |
@Corvince intriguing, I look forward to seeing what you are thinking. |
Yes, sorry for not stating my concerns directly, but I was on the move and just saw that recently there have been a lot of contributions to mesa, which is great, but I feared someone would start working on this directly. And I also wanted to commit myself ;) Anyways, I have 2 main concerns with instructing people to use git to clone the repository:
I am not sure what the best intermediant solution is, but the cleanest solution I always had on top of my mind was to create a |
That is a valid concern.
I don't think this is common. Most people will modify the examples code instead. #1275 may not be a comprehensive solution to the problem, but at least it makes the steps explicit, instead of assuming that people have already cloned the Git repo. People will see the If you notice, 2 of the comments in #315 stated the
As with improving the UX of running the examples starting with 0 knowledge in Python (IMO, this is a superset of the problem of this issue), this will take time to design. And so #1275 is a viable solution for now. In addition to |
#1228 is another option. |
Hmm I think we are getting somewhere, where we make too many assumptions on what people might or might not think. But I don't follow the argument why people would think But I totally agree that #1275 is an intermediant solution. In that case however I would prefer to also state the pitfalls explicitly. It is also not surprising that people mention git cloning, since this is currently required. Doesn't mean its a good solution. Case in point: If you clone the repo right now and try to run the Another example for executing an example is deploying it on Heroku: PR and example: https://mesa-schelling-example.herokuapp.com/ #1228 has the same discussion point as #568, namely whether the examples should be a part of mesa or inside their own repo (#134) |
Here are some data points:
This is a bug that needs to be addressed on its own. I don't recall any breaking changes between latest main and latest release (0.9.0), so something must have slipped through. I'd say the scope of this issue (#1274) should be limited to improving/clarifying the examples install instruction, and not more. We should discuss the general strategy on making it easy to run examples via Heroku demo, |
Don't worry you don't need to recall anything here. This was just an example. I also wouldn't consider it a bug, the state of mesa and the examples on the repo is consistent in itself. This is a general problem with the current structure. Try to install any older version of mesa and run the examples, a lot of them probably won't work. Just to be clear, I agree that #1275 is an immediate solution to this problem. And if someone has the time and energy to apply it to all examples feel free to do so - but it will be a change that should be reverted some time in the future when we have a better running-the-examples strategy. I am just not sure if it is worth the effort. (And I bet someone will eventually ask why the |
OK, this can be mitigated by doing I see #1275 as a complementary solution to |
But this is the other way around. This forces the mesa version to match the example. The usual need is to find examples matching the used version. Also, this obviously doesn't work for unreleased versions of mesa, i.e. changes in the main branch.
It depends on what solution we will come up with, but |
If you want examples that work on
Because some people (not all) prefer to see the source code, the exact commit hash, and the past revisions from Git. It's more transparent. |
If you look at https://github.com/projectmesa/mesa/graphs/traffic, #315 is the 3rd most visited page. This means that the readme of the examples are not clear enough to indicate that they must be in the directory containing the requirements.txt.
The text was updated successfully, but these errors were encountered: