feat(manager): add forbidden annotations, forbidden labels to service options #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for capsule-documentation canceled.
|
CharlieR-o-o-t
changed the title
prometherion
requested changes
Nov 15, 2023
CharlieR-o-o-t
changed the title
|
@CharlieR-o-o-t I improved the e2e test suite for the GH runners, may I ask you to rebase over |
|
@prometherion , rebased. seems tests are ok. |
… options Signed-off-by: Siarhei Rasiukevich <[email protected]>
prometherion
changed the title
prometherion
changed the title
Signed-off-by: Siarhei Rasiukevich <[email protected]>
prometherion
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forbidden Service labels/annotations for tenant.
Commit contains some refactoring to easy re-use metadata forbidden validation for any type of resource (Namespace, Service etc.)
closes #893
This PR contains changes related to this issue.