-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add clusterresources interception configuration #1003
feat: add clusterresources interception configuration #1003
Conversation
✅ Deploy Preview for capsule-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
Signed-off-by: Oliver Bähler <[email protected]>
9c41a84
to
f16a26a
Compare
Signed-off-by: Oliver Bähler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should start creating a separation of concerns between Capsule and its Proxy: since this is strictly related to the latter, shouldn't be better to move this logic there, as we did with the ProxySetting
?
@prometherion thanks for your review. Sure thing, but that would mean with a new stable release we would also remove the proxysettings on the ownerspec, correct? |
I'd say so, yes, especially considering we want to act as a framework. |
While most of the changes happen in the capsule-proxy (see the corresponding pull request: ) the owner spec for all the tenants is extended and the capsule-proxy uses this api definition.
With this change you have additional Control of cluster Resources
Note all the fields are marked as required. By default the List Operation is injected. We expect a selector to be set. This is not directly enforced with this approach, however it's the easiest way to go about this with clear documentation. Setting no selectors will have no impact on the proxy. If no requirements can be extracted, the
doesnotexist
Exists
requirement is added. Therefor preventing from listing all the resources.