Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactory messystore_item method #157

Open
mlitwiniuk opened this issue Nov 3, 2020 · 0 comments
Open

Refactory messystore_item method #157

mlitwiniuk opened this issue Nov 3, 2020 · 0 comments
Labels
enhancement refactor

Comments

@mlitwiniuk
Copy link
Member

This store_item method looks too messy to me. Maybe you could 1. remove commented transaction block 2. extract this lengthy conditional to separate method? However this would require handling startup_process variable differently. To be honest if startup_process is true most of this method is skipped entirely. Maybe startup_process can live in Lit.startup_process?

Originally posted by @pnikrat in #130 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlitwiniuk @pnikrat