Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor 2.0 Typography code to work with WebGL #7417

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Refactor 2.0 Typography code to work with WebGL #7417

merged 5 commits into from
Dec 11, 2024

Conversation

davepagurek
Copy link
Contributor

@davepagurek davepagurek commented Dec 7, 2024 •
edited
Loading

  • Give WebGL mode a small 2D canvas to use for text measurement
    • Fully get text measurement working
  • Move most Renderer2D functions to the base renderer
  • Make renderers separately implement functionality to get the text measurement context
  • Connect Typr glyph info to WebGL text shader
  • Connect WebGL glyph positioning to Typr positioning info
  • Fix bug: text wrapping not working in WebGL
  • Fix bug: text alignment not working in WebGL
  • Fix bug: Fonts loaded from file don't seem to work without a manual name supplied
  • Fix bug: 2D canvas extracts a different set of default parameters for variable fonts than Typr does, leading to misaligned WebGL text

@davepagurek davepagurek marked this pull request as ready for review December 11, 2024 23:00
@davepagurek davepagurek merged commit 8d5498d into dev-2.0 Dec 11, 2024
2 checks passed
@davepagurek davepagurek deleted the feat/webgl-fonts-2.0 branch December 11, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davepagurek