Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-use choices scores from trace when computing MH transition probabilities #906

Open
null-a opened this issue Jul 31, 2018 · 0 comments
Open

Re-use choices scores from trace when computing MH transition probabilities #906

null-a opened this issue Jul 31, 2018 · 0 comments

Comments

@null-a
Copy link
Member

null-a commented Jul 31, 2018

Since #905 was merged, we are storing the score of each individual choice/sample as part of the trace. (See here.) It looks like we can re-use these (rather than re-scoring) when computing MH transition probabilities, saving some work. i.e. here I guess we can replace choice.dist.score(choice.val) with choice.choiceScore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@null-a