Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to documentations in the tutorials #518

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

horizon-blue
Copy link
Member

In this PR I replaced all occurrences of "probcomp.github.io/Gen/dev" with "www.gen.dev/docs/stable", which is essentially equivalent to the changes in probcomp/gen-quickstart#91

(it will be nice if we can automatically sync the changes from gen-quickstart to the gh-pages branch of this main repo in the future).

@horizon-blue horizon-blue requested a review from ztangent January 11, 2024 20:24
@ztangent
Copy link
Member

Thank you!! I think we will also need to make the URL changes that were made in this PR to gen-quickstart, because the changes there never got synced to this branch.

Agreed that it'd be best to automatically sync the changes, but I'm not sure how to do that -- we'd somehow need to set up a Github Action that downloads the source code from gen-quickstart, compiles the Jupyter Notebooks into Markdown files, and then push to the gh-pages branch on this repository, which seems non trivial. I had been thinking that we could just do it manually this time around, but directly making these edits is also fine since it's a small change.

@horizon-blue
Copy link
Member Author

Thanks for the quick review, @ztangent! Yeah, I agree that cross-repo syncing can be a bit tricky to handle.

Just to clarify, do you mean that there are additional changes that I should make in this PR (or to gen-quickstart in addition to what's been covered in probcomp/gen-quickstart#91)?

@ztangent
Copy link
Member

Oops, I forgot to paste the link 🤦. I meant that there are URL changes made in this PR (probcomp/gen-quickstart#90) that we should also make in the Gen.jl repo.

@horizon-blue horizon-blue force-pushed the 20240111-xiaoyan-fixing-urls branch from 239af2f to 14d8ebc Compare January 11, 2024 21:20
@horizon-blue
Copy link
Member Author

Gotcha! I just updated this PR to replace all "www.gen.dev/dev/" with "www.gen.dev/docs/dev/" as well :)

@ztangent
Copy link
Member

Looks great to me!

@ztangent ztangent merged commit 1cfbfe0 into gh-pages Jan 12, 2024
@horizon-blue horizon-blue deleted the 20240111-xiaoyan-fixing-urls branch January 12, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants