Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove non-maintained MINERVA project #464

Open
haraldsteinlechner opened this issue Nov 20, 2024 · 2 comments
Open

remove non-maintained MINERVA project #464

haraldsteinlechner opened this issue Nov 20, 2024 · 2 comments

Comments

@haraldsteinlechner
Copy link
Collaborator

There is a lot of deprecated code in the repository we need to get rid of (current half-working state does not work when updating to dotnet8 etc). I propose to delete those code paths completely and get it back if needed at some point (a lot of effort to make it work anyways)

@haraldsteinlechner
Copy link
Collaborator Author

haraldsteinlechner commented Nov 20, 2024

@RebeccaNowak There is a lot of code referencing minerva datatypes in for example linking. Is it safe to remove those?
e.g.

type Action =
  | Camera           of FreeFlyController.Message
  | KeyUp            of key : Keys
  | KeyDown          of key : Keys  
  | UpdateDockConfig of DockConfig    
  | PickingAction    of PickingAction
  | LinkingAction    of LinkingAction
  | MinervaAction    of MinervaAction
  | PickPoint        of V3d

@RebeccaNowak
Copy link
Collaborator

I wasn't involved in Minerva, but I think we can remove them since Minerva isn't being used anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants